Add option for host address in echo server and MQTT broker #113
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-josi-aws
changed the title
amazonKamath
previously approved these changes
Dec 8, 2024
kar-rahul-aws
approved these changes
Dec 17, 2024
ActoryOu
approved these changes
Dec 17, 2024
aggarg
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Failure of +TCP/MQTT demos on the CI when the latest version of +TCP is used.
Description of changes:
This PR allows to optionally use the specified IP address as the host address while creating echo server and MQTT broker.
This change is required to make the latest version of +TCP simulated-based demos work on the CI.
When +TCP simulated demos are run, they don't use the existing endpoint of the host system (Linux/Windows), instead create its own network endpoint. The fixes for loopback-related issues in the latest version of +TCP make it impossible to communicate with loopback addresses that are outside of the demo (in this case, the echo server/MQTT broker runs on the host system's endpoint where simulated demos are run).
The changes are tested here:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.